niyue commented on a change in pull request #11486:
URL: https://github.com/apache/arrow/pull/11486#discussion_r740209418
##########
File path: cpp/src/arrow/io/memory.h
##########
@@ -171,8 +171,8 @@ class ARROW_EXPORT BufferReader
Result<int64_t> DoRead(int64_t nbytes, void* buffer);
Result<std::shared_ptr<Buffer>> DoRead(int64_t nbytes);
- Result<int64_t> DoReadAt(int64_t position, int64_t nbytes, void* out);
- Result<std::shared_ptr<Buffer>> DoReadAt(int64_t position, int64_t nbytes);
+ virtual Result<int64_t> DoReadAt(int64_t position, int64_t nbytes, void*
out);
+ virtual Result<std::shared_ptr<Buffer>> DoReadAt(int64_t position, int64_t
nbytes);
Review comment:
As said above, these two `DoReadAt` are changed to `virtual` so that
they can be overridden and mock fs could use them for collecting the read
stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
