alamb commented on a change in pull request #1062: URL: https://github.com/apache/arrow-datafusion/pull/1062#discussion_r740941986
########## File path: datafusion/src/datasource/object_store/hdfs/os_parquet.rs ########## @@ -0,0 +1,102 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Parquet related things for hdfs object store +use std::io::{Read, Seek, SeekFrom}; +use std::sync::Arc; + +use parquet::file::reader::{ChunkReader, Length}; +use parquet::util::io::{FileSource, TryClone}; + +use crate::datasource::object_store::hdfs::{to_error, HadoopFileSystem}; +use crate::datasource::object_store::ObjectReader; +use crate::datasource::parquet::dynamic_reader::{DynChunkReader, DynRead}; + +use super::HadoopFile; +use crate::error::Result; + +/// Parquet file reader for hdfs object store, by which we can get ``DynChunkReader`` +#[derive(Clone)] +pub struct HadoopParquetFileReader { Review comment: HI @yahoNanJing -- if you have time here is what I recommend: 1. Make a draft PR to this (arrow-datafusion) repo (so the conversation can include the code) 2. Leave a note in the PR's description that you are looking for feedback about where to put the connector (this repo or a separate one) 3. Then send a note to the [email protected] mailing list (or I can do this too) with a reference to the PR asking if anyone has feedback. I have my own opinions on this matter, but I think we should get broader input before making a decision -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
