lidavidm commented on a change in pull request #11466:
URL: https://github.com/apache/arrow/pull/11466#discussion_r741075422
##########
File path: cpp/src/arrow/array/array_nested.h
##########
@@ -370,6 +370,13 @@ class ARROW_EXPORT StructArray : public Array {
/// \param[in] pool The pool to allocate null bitmaps from, if necessary
Result<ArrayVector> Flatten(MemoryPool* pool = default_memory_pool()) const;
+ /// \brief Get one of the child arrays, adjusting the null bitmap if
necessary.
+ ///
+ /// \param[in] index Which child array to get
+ /// \param[in] pool The pool to allocate null bitmaps from, if necessary
+ Result<std::shared_ptr<Array>> Flatten(int index,
Review comment:
We could call it `MakeFlattenedChild` or `GetFlattenedChild` or
something if that helps? I agree Flatten isn't the best name when it comes to a
single child array.
##########
File path: cpp/src/arrow/compute/exec/expression.h
##########
@@ -112,7 +113,7 @@ class ARROW_EXPORT Expression {
// post-bind properties
ValueDescr descr;
- int index;
+ internal::SmallVector<int, 2> indices;
Review comment:
It's the number of items that can be stored before it changes from a
stack-based to heap-based representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
