niyue commented on a change in pull request #11486:
URL: https://github.com/apache/arrow/pull/11486#discussion_r741101618



##########
File path: cpp/src/arrow/ipc/reader.h
##########
@@ -212,6 +212,53 @@ class ARROW_EXPORT RecordBatchFileReader
       arrow::internal::Executor* executor = NULLPTR) = 0;
 };
 
+/// \class IoRecordedRandomAccessFile
+/// \brief An RandomAccessFile that doesn't perform real IO, but only save all 
the IO
+/// operations it receives, including read operation's <offset, length>, for 
replaying
+/// later
+class ARROW_EXPORT IoRecordedRandomAccessFile : public io::RandomAccessFile {

Review comment:
       Fixed. Now I added a new header file called `reader_internal.h` and put 
this class into it, and its implementation is still in `reader.cc`. I find 
there are other internal classes in `reader.h` but to keep the change minimum 
so far I don't move them into `read_internal.h` in this PR. Let me know if 
other changes are needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to