bkietz commented on a change in pull request #11384:
URL: https://github.com/apache/arrow/pull/11384#discussion_r741204453
##########
File path: cpp/src/arrow/scalar.h
##########
@@ -302,7 +302,7 @@ struct TemporalScalar : internal::PrimitiveScalar<T> {
using internal::PrimitiveScalar<T>::PrimitiveScalar;
using ValueType = typename TemporalScalar<T>::ValueType;
- explicit TemporalScalar(ValueType value, std::shared_ptr<DataType> type)
+ TemporalScalar(ValueType value, std::shared_ptr<DataType> type)
Review comment:
If the constructor could accept a single argument, `explicit` would
allow implicit conversion to `TemporalScalar`. Since the constructor requires
two arguments the keyword is fully redundant (which clang-tidy nagged me about
when I opened the file, prompting the edit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
