westonpace commented on pull request #11590:
URL: https://github.com/apache/arrow/pull/11590#issuecomment-958028544


   @aocsa Not high priority
   
   > Also, the test AddAfterWaitButBeforeFinish checks that we can add tasks 
after calling End()
   
   @lidavidm 
   
   Thanks for the catch, I'll fix that.  At the time, I had envisioned that 
child tasks might still need to add tasks to the task group after the parent 
ended it.  However, having using AsyncTaskGroup for some time now, I'm pretty 
sure the correct solution is either:
   
    1. Chain the follow up tasks and add the last task in the chain to the task 
group
    2. Use nested AsyncTaskGroup
    
    So I will remove that test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to