vvellanki commented on a change in pull request #11287:
URL: https://github.com/apache/arrow/pull/11287#discussion_r741638784
##########
File path: cpp/src/gandiva/function_registry_string.cc
##########
@@ -406,6 +406,10 @@ std::vector<NativeFunction> GetStringFunctionRegistry() {
NativeFunction("split_part", {}, DataTypeVector{utf8(), utf8(),
int32()}, utf8(),
kResultNullIfNull, "split_part",
+ NativeFunction::kNeedsContext |
NativeFunction::kCanReturnErrors),
+
+ NativeFunction("instr", {}, DataTypeVector{utf8(), utf8()}, int32(),
+ kResultNullIfNull, "gd_fn_instr_utf8",
Review comment:
Why does this function need context? I also dont see this function
return errors
Do we need the kNeedsContext and kCanReturnErrors flags?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
