jorisvandenbossche commented on a change in pull request #11023:
URL: https://github.com/apache/arrow/pull/11023#discussion_r741811378
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -1041,6 +1037,73 @@ TYPED_TEST(TestStringKernels, Utf8Title) {
R"([null, "", "B", "Aaaz;Zææ&", "Ɑɽɽow", "Ii", "Ⱥ.Ⱥ.Ⱥ..Ⱥ", "Hello,
World!", "Foo Bar;Héhé0Zop", "!%$^.,;"])");
}
+TYPED_TEST(TestStringKernels, BinaryRepeatWithScalarRepeat) {
+ auto values = ArrayFromJSON(this->type(),
+ R"(["aAazZæÆ&", null, "", "b", "ɑɽⱤoW", "ıI",
+ "ⱥⱥⱥȺ", "hEllO, WoRld!", "$. A3",
"!ɑⱤⱤow"])");
+ std::vector<std::pair<int, std::string>> nrepeats_and_expected{{
+ {0, R"(["", null, "", "", "", "", "", "", "", ""])"},
+ {1, R"(["aAazZæÆ&", null, "", "b", "ɑɽⱤoW", "ıI", "ⱥⱥⱥȺ", "hEllO,
WoRld!",
+ "$. A3", "!ɑⱤⱤow"])"},
+ {4, R"(["aAazZæÆ&aAazZæÆ&aAazZæÆ&aAazZæÆ&", null, "", "bbbb",
+ "ɑɽⱤoWɑɽⱤoWɑɽⱤoWɑɽⱤoW", "ıIıIıIıI", "ⱥⱥⱥȺⱥⱥⱥȺⱥⱥⱥȺⱥⱥⱥȺ",
+ "hEllO, WoRld!hEllO, WoRld!hEllO, WoRld!hEllO, WoRld!",
+ "$. A3$. A3$. A3$. A3", "!ɑⱤⱤow!ɑⱤⱤow!ɑⱤⱤow!ɑⱤⱤow"])"},
+ }};
+
+ for (const auto& pair : nrepeats_and_expected) {
+ auto num_repeat = pair.first;
+ auto expected = pair.second;
+ for (const auto& ty : IntTypes()) {
+ this->CheckVarArgs("binary_repeat",
+ {values, Datum(*arrow::MakeScalar(ty, num_repeat))},
+ this->type(), expected);
+ }
+ }
+
+ // Negative repeat count
+ for (auto num_repeat_ : {-1, -2, -5}) {
+ auto num_repeat = *arrow::MakeScalar(int64(), num_repeat_);
+ EXPECT_RAISES_WITH_MESSAGE_THAT(
+ Invalid, ::testing::HasSubstr("Repeat count must be a non-negative
integer"),
+ CallFunction("binary_repeat", {values, num_repeat}));
+ }
+
+ // Floating-point repeat count
+ for (auto num_repeat_ : {0.0, 1.2, -1.3}) {
+ auto num_repeat = *arrow::MakeScalar(float64(), num_repeat_);
+ EXPECT_RAISES_WITH_MESSAGE_THAT(
+ NotImplemented, ::testing::HasSubstr("has no kernel matching input
types"),
+ CallFunction("binary_repeat", {values, num_repeat}));
+ }
+}
+
+TYPED_TEST(TestStringKernels, BinaryRepeatWithArrayRepeat) {
+ auto values = ArrayFromJSON(this->type(),
+ R"([null, "aAazZæÆ&", "", "b", "ɑɽⱤoW", "ıI",
+ "ⱥⱥⱥȺ", "hEllO, WoRld!", "$. A3",
"!ɑⱤⱤow"])");
+ for (const auto& ty : IntTypes()) {
+ auto num_repeats = ArrayFromJSON(ty, R"([100, 1, 2, 5, 2, 0, 1, 3, 2,
3])");
Review comment:
Maybe also add a null in the num_repeats? (as that is allowed and will
give a null in the result)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
