pitrou commented on a change in pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#discussion_r741969842
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -30,6 +30,10 @@
#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"
+#ifdef ARROW_WITH_UTF8PROC
+#include <utf8proc.h>
Review comment:
We shouldn't include utf8proc in public headers, IMHO. This is only
necessary for the kernel implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
