roee88 commented on a change in pull request #11543:
URL: https://github.com/apache/arrow/pull/11543#discussion_r742250034
##########
File path: docker-compose.yml
##########
@@ -993,6 +994,39 @@ services:
/arrow/ci/scripts/java_build.sh /arrow /build &&
/arrow/ci/scripts/python_test.sh /arrow"]
+ conda-python-java-integration:
+ # Usage:
+ # docker-compose build conda
+ # docker-compose build conda-cpp
+ # docker-compose build conda-python
+ # docker-compose build conda-python-java-integration
+ # docker-compose run --rm conda-python-java-integration
+ image: ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ build:
+ context: .
+ dockerfile: ci/docker/conda-python-jpype.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ args:
+ repo: ${REPO}
+ arch: ${ARCH}
+ python: ${PYTHON}
+ llvm: ${LLVM}
+ shm_size: *shm-size
+ environment:
+ <<: *ccache
+ ARROW_JAVA_CDATA: "ON"
+ volumes:
+ - .:/arrow:delegated
+ - ${DOCKER_VOLUME_PREFIX}maven-cache:/root/.m2:delegated
+ - ${DOCKER_VOLUME_PREFIX}debian-ccache:/ccache:delegated
+ command:
+ [ "/arrow/ci/scripts/cpp_build.sh /arrow /build &&
+ /arrow/ci/scripts/python_build.sh /arrow /build &&
Review comment:
@pitrou the reason was to do the integration test against the code in
the main branch for cases where related fixes are made to the python/C++
implementation. It seems like this is what conda-python-jpype does. If
undesired then we can switch to just `pip install` (which was @tomersolomon1's
original intent, so my bad)
##########
File path: docker-compose.yml
##########
@@ -993,6 +994,39 @@ services:
/arrow/ci/scripts/java_build.sh /arrow /build &&
/arrow/ci/scripts/python_test.sh /arrow"]
+ conda-python-java-integration:
+ # Usage:
+ # docker-compose build conda
+ # docker-compose build conda-cpp
+ # docker-compose build conda-python
+ # docker-compose build conda-python-java-integration
+ # docker-compose run --rm conda-python-java-integration
+ image: ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ build:
+ context: .
+ dockerfile: ci/docker/conda-python-jpype.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ args:
+ repo: ${REPO}
+ arch: ${ARCH}
+ python: ${PYTHON}
+ llvm: ${LLVM}
+ shm_size: *shm-size
+ environment:
+ <<: *ccache
+ ARROW_JAVA_CDATA: "ON"
+ volumes:
+ - .:/arrow:delegated
+ - ${DOCKER_VOLUME_PREFIX}maven-cache:/root/.m2:delegated
+ - ${DOCKER_VOLUME_PREFIX}debian-ccache:/ccache:delegated
+ command:
+ [ "/arrow/ci/scripts/cpp_build.sh /arrow /build &&
+ /arrow/ci/scripts/python_build.sh /arrow /build &&
Review comment:
@pitrou the reason was to do the integration test against the code in
the main branch for cases where related fixes are made to the python/C++
implementation. It seems like this is what conda-python-jpype does. If
undesired then we can switch to just `pip install` (which was @tomersolomon1's
original intent, so my bad)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
