houqp commented on a change in pull request #1235:
URL: https://github.com/apache/arrow-datafusion/pull/1235#discussion_r742454597
##########
File path: datafusion/src/physical_plan/expressions/min_max.rs
##########
@@ -72,15 +81,15 @@ impl AggregateExpr for Max {
fn field(&self) -> Result<Field> {
Ok(Field::new(
&self.name,
- self.data_type.clone(),
+ min_max_aggregate_data_type(self.data_type.clone()),
Review comment:
since `min_max_aggregate_data_type` is already performing clone
internally, perhaps we can just pass by reference here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
