edponce commented on a change in pull request #11023:
URL: https://github.com/apache/arrow/pull/11023#discussion_r741755299



##########
File path: r/R/expression.R
##########
@@ -100,7 +100,8 @@
   # use `%/%` above.
   "%%" = "divide_checked",
   "^" = "power_checked",
-  "%in%" = "is_in_meta_binary"
+  "%in%" = "is_in_meta_binary",
+  "strrep" = "binary_repeat"

Review comment:
       Good to know. Thanks!

##########
File path: r/R/expression.R
##########
@@ -100,7 +100,8 @@
   # use `%/%` above.
   "%%" = "divide_checked",
   "^" = "power_checked",
-  "%in%" = "is_in_meta_binary"
+  "%in%" = "is_in_meta_binary",
+  "strrep" = "binary_repeat"

Review comment:
       There is a minor difference in behavior when given a negative repeat 
count:
   * `binary_repeat` and `strrep` return an error
   * `str_dup` returns `NA`

##########
File path: r/R/expression.R
##########
@@ -100,7 +100,8 @@
   # use `%/%` above.
   "%%" = "divide_checked",
   "^" = "power_checked",
-  "%in%" = "is_in_meta_binary"
+  "%in%" = "is_in_meta_binary",
+  "strrep" = "binary_repeat"

Review comment:
       Good to know. Thanks!

##########
File path: r/R/expression.R
##########
@@ -100,7 +100,8 @@
   # use `%/%` above.
   "%%" = "divide_checked",
   "^" = "power_checked",
-  "%in%" = "is_in_meta_binary"
+  "%in%" = "is_in_meta_binary",
+  "strrep" = "binary_repeat"

Review comment:
       There is a minor difference in behavior when given a negative repeat 
count:
   * `binary_repeat` and `strrep` return an error
   * `str_dup` returns `NA`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to