alamb commented on a change in pull request #888:
URL: https://github.com/apache/arrow-rs/pull/888#discussion_r742239117
##########
File path: arrow/src/json/reader.rs
##########
@@ -1015,7 +1015,15 @@ impl Decoder {
DataType::UInt32 =>
self.read_primitive_list_values::<UInt32Type>(rows),
DataType::UInt64 =>
self.read_primitive_list_values::<UInt64Type>(rows),
DataType::Float16 => {
- return Err(ArrowError::JsonError("Float16 not
supported".to_string()))
+ #[cfg(feature = "f16")]
Review comment:
Same question applies below
##########
File path: arrow/src/json/reader.rs
##########
@@ -1015,7 +1015,15 @@ impl Decoder {
DataType::UInt32 =>
self.read_primitive_list_values::<UInt32Type>(rows),
DataType::UInt64 =>
self.read_primitive_list_values::<UInt64Type>(rows),
DataType::Float16 => {
- return Err(ArrowError::JsonError("Float16 not
supported".to_string()))
+ #[cfg(feature = "f16")]
Review comment:
this seems redundant -- both branches do the same thing. Was this an
oversight? Or perhaps just a future TODO that will be clearer when separated
like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
