pitrou commented on a change in pull request #11543:
URL: https://github.com/apache/arrow/pull/11543#discussion_r741897046
##########
File path: docker-compose.yml
##########
@@ -993,6 +994,39 @@ services:
/arrow/ci/scripts/java_build.sh /arrow /build &&
/arrow/ci/scripts/python_test.sh /arrow"]
+ conda-python-java-integration:
+ # Usage:
+ # docker-compose build conda
+ # docker-compose build conda-cpp
+ # docker-compose build conda-python
+ # docker-compose build conda-python-java-integration
+ # docker-compose run --rm conda-python-java-integration
+ image: ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ build:
+ context: .
+ dockerfile: ci/docker/conda-python-jpype.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ args:
+ repo: ${REPO}
+ arch: ${ARCH}
+ python: ${PYTHON}
+ llvm: ${LLVM}
+ shm_size: *shm-size
+ environment:
+ <<: *ccache
+ ARROW_JAVA_CDATA: "ON"
+ volumes:
+ - .:/arrow:delegated
+ - ${DOCKER_VOLUME_PREFIX}maven-cache:/root/.m2:delegated
+ - ${DOCKER_VOLUME_PREFIX}debian-ccache:/ccache:delegated
+ command:
+ [ "/arrow/ci/scripts/cpp_build.sh /arrow /build &&
+ /arrow/ci/scripts/python_build.sh /arrow /build &&
Review comment:
I don't think you _need_ to build Arrow C++ and PyArrow from scratch.
You should be able to just `pip install` a recent binary wheel. Did you try to
do that?
##########
File path: docker-compose.yml
##########
@@ -993,6 +994,39 @@ services:
/arrow/ci/scripts/java_build.sh /arrow /build &&
/arrow/ci/scripts/python_test.sh /arrow"]
+ conda-python-java-integration:
+ # Usage:
+ # docker-compose build conda
+ # docker-compose build conda-cpp
+ # docker-compose build conda-python
+ # docker-compose build conda-python-java-integration
+ # docker-compose run --rm conda-python-java-integration
+ image: ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ build:
+ context: .
+ dockerfile: ci/docker/conda-python-jpype.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ args:
+ repo: ${REPO}
+ arch: ${ARCH}
+ python: ${PYTHON}
+ llvm: ${LLVM}
+ shm_size: *shm-size
+ environment:
+ <<: *ccache
+ ARROW_JAVA_CDATA: "ON"
+ volumes:
+ - .:/arrow:delegated
+ - ${DOCKER_VOLUME_PREFIX}maven-cache:/root/.m2:delegated
+ - ${DOCKER_VOLUME_PREFIX}debian-ccache:/ccache:delegated
+ command:
+ [ "/arrow/ci/scripts/cpp_build.sh /arrow /build &&
+ /arrow/ci/scripts/python_build.sh /arrow /build &&
Review comment:
Incidentally, this is what Go does for a similar purpose:
https://github.com/apache/arrow/blob/master/ci/docker/debian-10-go-cgo-python.dockerfile#L23-L36
##########
File path: docker-compose.yml
##########
@@ -993,6 +994,39 @@ services:
/arrow/ci/scripts/java_build.sh /arrow /build &&
/arrow/ci/scripts/python_test.sh /arrow"]
+ conda-python-java-integration:
+ # Usage:
+ # docker-compose build conda
+ # docker-compose build conda-cpp
+ # docker-compose build conda-python
+ # docker-compose build conda-python-java-integration
+ # docker-compose run --rm conda-python-java-integration
+ image: ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ build:
+ context: .
+ dockerfile: ci/docker/conda-python-jpype.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-conda-python-${PYTHON}-java-integration
+ args:
+ repo: ${REPO}
+ arch: ${ARCH}
+ python: ${PYTHON}
+ llvm: ${LLVM}
+ shm_size: *shm-size
+ environment:
+ <<: *ccache
+ ARROW_JAVA_CDATA: "ON"
+ volumes:
+ - .:/arrow:delegated
+ - ${DOCKER_VOLUME_PREFIX}maven-cache:/root/.m2:delegated
+ - ${DOCKER_VOLUME_PREFIX}debian-ccache:/ccache:delegated
+ command:
+ [ "/arrow/ci/scripts/cpp_build.sh /arrow /build &&
+ /arrow/ci/scripts/python_build.sh /arrow /build &&
Review comment:
As you prefer, though this certainly makes the CI and docker run slower
than installing a binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
