xudong963 commented on a change in pull request #1202:
URL: https://github.com/apache/arrow-datafusion/pull/1202#discussion_r742815701
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1972,10 +1972,31 @@ fn create_name(e: &Expr, input_schema: &DFSchema) ->
Result<String> {
Ok(format!("{} IN ({:?})", expr, list))
}
}
- other => Err(DataFusionError::NotImplemented(format!(
- "Create name does not support logical expression {:?}",
- other
- ))),
+ Expr::Between {
+ expr,
+ negated,
+ low,
+ high,
+ } => {
+ let expr = create_name(expr, input_schema)?;
+ let low = create_name(low, input_schema)?;
+ let high = create_name(high, input_schema)?;
+ if *negated {
+ Ok(format!("{} NOT BETWEEN {} AND {}", expr, low, high))
+ } else {
+ Ok(format!("{} BETWEEN {} AND {}", expr, low, high))
+ }
+ }
+ Expr::Sort {
Review comment:
You can directly use `Expr::Sort{ .. }`
##########
File path: datafusion/src/physical_plan/planner.rs
##########
@@ -182,10 +182,31 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) ->
Result<String> {
Ok(format!("{} IN ({:?})", expr, list))
}
}
- other => Err(DataFusionError::NotImplemented(format!(
- "Cannot derive physical field name for logical expression {:?}",
- other
- ))),
+ Expr::Between {
+ expr,
+ negated,
+ low,
+ high,
+ } => {
+ let expr = create_physical_name(expr, false)?;
+ let low = create_physical_name(low, false)?;
+ let high = create_physical_name(high, false)?;
+ if *negated {
+ Ok(format!("{} NOT BETWEEN {} AND {}", expr, low, high))
+ } else {
+ Ok(format!("{} BETWEEN {} AND {}", expr, low, high))
+ }
+ }
+ Expr::Sort {
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
