Dandandan commented on a change in pull request #1237:
URL: https://github.com/apache/arrow-datafusion/pull/1237#discussion_r742916293
##########
File path: datafusion/src/sql/parser.rs
##########
@@ -294,7 +294,7 @@ impl<'a> DFParser<'a> {
}
fn consume_token(&mut self, expected: &str) -> bool {
Review comment:
This method could take a token instead of a `&str` removing the need to
convert it to a string again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
