jhorstmann commented on a change in pull request #810:
URL: https://github.com/apache/arrow-rs/pull/810#discussion_r743024733
##########
File path: arrow/src/datatypes/datatype.rs
##########
@@ -477,6 +477,15 @@ impl DataType {
)
}
+ /// Returns true if this type is integral: (UInt*, Unit*).
+ pub fn is_integer(t: &DataType) -> bool {
Review comment:
This seems to be only used for validating dictionary key types, maybe
rename to `is_dictionary_key_type` and link the `ArrowDictionaryKeyType` trait
in the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
