augustoasilva commented on a change in pull request #11551:
URL: https://github.com/apache/arrow/pull/11551#discussion_r743325850
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -794,6 +795,83 @@ const char* gdv_fn_initcap_utf8(int64_t context, const
char* data, int32_t data_
*out_len = out_idx;
return out;
}
+
+GANDIVA_EXPORT
+const char* gdv_fn_mask_first_n(int64_t context, const char* data, int32_t
data_len,
+ int32_t n_to_mask, int32_t* out_len) {
+ if (data_len <= 0) {
+ *out_len = 0;
+ return "";
Review comment:
Yes, it should, so I fixed
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -794,6 +795,83 @@ const char* gdv_fn_initcap_utf8(int64_t context, const
char* data, int32_t data_
*out_len = out_idx;
return out;
}
+
+GANDIVA_EXPORT
+const char* gdv_fn_mask_first_n(int64_t context, const char* data, int32_t
data_len,
+ int32_t n_to_mask, int32_t* out_len) {
+ if (data_len <= 0) {
+ *out_len = 0;
+ return "";
+ }
+
+ std::string str(data, data_len);
+ int32_t counter = 0;
+ for (char& c : str) {
Review comment:
I did a new implementation without std::string, and more simple and
efficiente on the for loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
