jonkeane commented on a change in pull request #11592:
URL: https://github.com/apache/arrow/pull/11592#discussion_r743034726
##########
File path: r/R/dplyr-functions.R
##########
@@ -848,6 +844,21 @@ nse_funcs$wday <- function(x,
Expression$create("day_of_week", x, options = list(count_from_zero = FALSE,
week_start = week_start))
}
+nse_funcs$is.Date <- function(x) {
+ inherits(x, "Date") ||
+ (inherits(x, "Expression") && x$type_id() %in% Type[c("DATE32")])
Review comment:
I think we want `DATE64` in here as well since those are treated as
dates in other areas (even though they do have a bit funny millisecond
precision). Possibly also below for `is.instant()` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
