alamb commented on pull request #1245: URL: https://github.com/apache/arrow-datafusion/pull/1245#issuecomment-961978601
> @xudong963 Those are great queries. I have tried to add them in the test but I think we have not done constant folding for Between yet (or at least not for the queries in your examples) so they are not folded at this time. Hence, I do not commit them in because they are the same as the current between query. > > I can open a new ticket for improving these cases though. What do you think @alamb ? I think the constant folding is handled by `ConstEvaluator` (in a different module). The `Simplifier` is supposed to be focused on items that can't be folded (like `TRUE OR <expr>` --> `<expr>`). The fact we have some boolean constant evaluation in here is a historical artifact and due to the fact we don't have full expression evaluation support for all boolean operations (yet). Thus I don't think a separate ticket is needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
