cpcloud commented on a change in pull request #11627:
URL: https://github.com/apache/arrow/pull/11627#discussion_r743959763



##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##########
@@ -1496,13 +1496,19 @@ TEST_F(TestUnaryArithmeticDecimal, AbsoluteValue) {
       CheckScalar(func, {ArrayFromJSON(ty, R"(["1.00", "-42.15", null])")},

Review comment:
       I think I'm just dumb, but why don't these calls also require explicit 
construction?

##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##########
@@ -1496,13 +1496,19 @@ TEST_F(TestUnaryArithmeticDecimal, AbsoluteValue) {
       CheckScalar(func, {ArrayFromJSON(ty, R"(["1.00", "-42.15", null])")},

Review comment:
       Awesome.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to