augustoasilva commented on a change in pull request #11415:
URL: https://github.com/apache/arrow/pull/11415#discussion_r744026978
##########
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##########
@@ -120,6 +120,46 @@ TEST(TestExtendedMathOps, TestRoundDecimal) {
VerifyFuzzyEquals(round_float64_int32((double)INT_MIN - 1, 0),
(double)INT_MIN - 1);
}
+TEST(TestExtendedMathOps, TestBRoundDecimal) {
+ EXPECT_DOUBLE_EQ(bround_float64(0.0), 0);
+ EXPECT_DOUBLE_EQ(bround_float64(2.5), 2);
+ EXPECT_DOUBLE_EQ(bround_float64(3.5), 4);
+ EXPECT_DOUBLE_EQ(bround_float64(-2.5), -2);
+ EXPECT_DOUBLE_EQ(bround_float64(-3.5), -4);
+ EXPECT_DOUBLE_EQ(bround_float64(1.4999999), 1);
+ EXPECT_EQ(std::signbit(bround_float64(0)), 0);
+ EXPECT_EQ(std::signbit(bround_float64(0)), 0);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(8.25, 1), 8.2);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(8.35, 1), 8.4);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(6.225, 2), 6.22);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(8.335, 2), 8.34);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(-8.25, 1), -8.2);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(-8.35, 1), -8.4);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(-6.225, 2), -6.22);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(-8.335, 2), -8.34);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(-6.225, -2), -6.22);
+ EXPECT_DOUBLE_EQ(bround_float64_int32(8.335, -2), 8.34);
+
+ VerifyFuzzyEquals(bround_float64(2.5), 2);
Review comment:
VerifyFuzzyEquals has a tolefrance to be almost equal, not exactly the
same number. Should I remove VerifyFuzzyEquals test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
