houqp commented on a change in pull request #1258:
URL: https://github.com/apache/arrow-datafusion/pull/1258#discussion_r744178212



##########
File path: datafusion/src/execution/dataframe_impl.rs
##########
@@ -231,6 +231,29 @@ impl DataFrame for DataFrameImpl {
                 .build()?,
         )))
     }
+
+    fn intersect(&self, dataframe: Arc<dyn DataFrame>) -> Result<Arc<dyn 
DataFrame>> {

Review comment:
       looks like there is some code duplication between this and the one in 
sql planner, perhaps better to move this into logical plan builder so it can be 
reused in both places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to