pitrou commented on a change in pull request #11623:
URL: https://github.com/apache/arrow/pull/11623#discussion_r744815935
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc
##########
@@ -692,6 +699,24 @@ TEST(GroupBy, Errors) {
batch->GetColumnByName("group_id")}),
Raises(StatusCode::NotImplemented,
HasSubstr("Direct execution of HASH_AGGREGATE
functions")));
+
+ // Regression test for ARROW-14583: handle when no batches are
Review comment:
Since this is not testing an error condition, should you create a
separate test case for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
