westonpace commented on a change in pull request #11640:
URL: https://github.com/apache/arrow/pull/11640#discussion_r745043272
##########
File path: cpp/src/arrow/compute/exec/aggregate_node.cc
##########
@@ -525,9 +525,8 @@ class GroupByNode : public ExecNode {
void StopProducing(ExecNode* output) override {
DCHECK_EQ(output, outputs_[0]);
- if (input_counter_.Cancel()) {
- finished_.MarkFinished();
- } else if (output_counter_.Cancel()) {
+ ARROW_UNUSED(input_counter_.Cancel());
Review comment:
Looks good. I don't know if you even need to call
`input_counter_.Cancel()` here but I also suppose it can't hurt and maybe it
will save some extra work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
