jonkeane commented on a change in pull request #11534:
URL: https://github.com/apache/arrow/pull/11534#discussion_r745149729
##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -317,3 +317,7 @@ split_vector_as_list <- function(vec) {
vec2 <- vec[seq(from = min(length(vec), vec_split + 1), to = length(vec), by
= 1)]
list(vec1, vec2)
}
+
+err_helper <- function(...) (expect_error(...))
Review comment:
I like the helpers and that they reduce some of the boiler plate. Any
reason not to make them simply `err()` and `warn()` or maybe `err_snap()` and
`warn_snap()` to make it clear that they are for use with snapshots?
If the reason you were thinking of avoiding them is to avoid running into
testthat's version if they implement them, it [looks like they aren't planning
to](https://github.com/r-lib/testthat/issues/1471#issuecomment-962982383)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
