ZMZ91 commented on a change in pull request #11016:
URL: https://github.com/apache/arrow/pull/11016#discussion_r745261537
##########
File path: cpp/src/gandiva/precompiled/string_ops.cc
##########
@@ -1790,8 +1816,10 @@ const char* lpad_utf8_int32_utf8(gdv_int64 context,
const char* text, gdv_int32
// case (return_length > text_char_count)
// case where it needs to copy "fill_text" on the string left. The total
number
// of chars to copy is given by (return_length - text_char_count)
- char* ret =
- reinterpret_cast<gdv_binary>(gdv_fn_context_arena_malloc(context,
return_length));
+ gdv_int32 return_char_length = evaluate_return_char_length(
Review comment:
Changed to actual_text_len. @rkavanap if no more issues, could you help
merge this pr since it's been quite a while since open. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
