dragosmg commented on a change in pull request #11534:
URL: https://github.com/apache/arrow/pull/11534#discussion_r745461259
##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -317,3 +317,7 @@ split_vector_as_list <- function(vec) {
vec2 <- vec[seq(from = min(length(vec), vec_split + 1), to = length(vec), by
= 1)]
list(vec1, vec2)
}
+
+err_helper <- function(...) (expect_error(...))
Review comment:
In this specific instance - a wrapper that is very close to the actual
function and does not add much in terms of complexity + is not user facing -
I'd be in favour of a shorter name (like the initial `err()`). In order to
prevent conflicts with {rlang} I think adding the __snap_ prefix should do. So
my vote goes for `err_snap()` and `warn_snap()` and maybe, if needed a
`mess_snap()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
