alamb commented on a change in pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#discussion_r745519857
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
@brackle-lattice - here is a PR to your branch to pickup changes from
master as well as add a test showing what happens with `2.` (it is parsed as
`Utf8`). https://github.com/brianrackle/arrow-rs/pull/1 (github shows the full
diff which is somewhat silly, as it is a merge commit and then a 2 line
change). I think what that change this PR will be ready to go
If you don't have time to merge it I can also create a new PR with the
changes too to get it into arrow-rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
