alamb commented on a change in pull request #928:
URL: https://github.com/apache/arrow-rs/pull/928#discussion_r745524239
##########
File path: arrow/src/error.rs
##########
@@ -41,6 +41,7 @@ pub enum ArrowError {
/// Error during import or export to/from the C Data Interface
CDataInterface(String),
DictionaryKeyOverflowError,
+ DecimalError(String),
Review comment:
Adding a new variant to this `enum` makes the change, strictly speaking,
not backwards compatible.
I think we should use `InvalidArgumentError` rather than adding a new
variant in order to be consistent with the rest of the codebase as well as
ensure this change is backwards compatible (and can be included in the 6.2.0
release)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
