save-buffer commented on a change in pull request #11579:
URL: https://github.com/apache/arrow/pull/11579#discussion_r745956818
##########
File path: cpp/src/arrow/compute/exec/hash_join.cc
##########
@@ -282,6 +279,125 @@ class HashJoinBasicImpl : public HashJoinImpl {
num_batches_produced_++;
}
+ Status ProbeBatch_ResidualFilter(ThreadLocalState& local_state,
+ std::vector<int32_t>& match,
+ std::vector<int32_t>& no_match,
+ std::vector<int32_t>& match_left,
+ std::vector<int32_t>& match_right) {
+ if (filter_ == literal(true)) {
+ return Status::OK();
+ }
+ ARROW_DCHECK_EQ(match_left.size(), match_right.size());
+
+ ExecBatch concatenated({}, match_left.size());
+
+ ARROW_ASSIGN_OR_RAISE(ExecBatch left_key,
local_state.exec_batch_keys.Decode(
+ match_left.size(),
match_left.data()));
+ ARROW_ASSIGN_OR_RAISE(
+ ExecBatch right_key,
+ hash_table_keys_.Decode(match_right.size(), match_right.data()));
+
+ ExecBatch left_payload;
+ if (!schema_mgr_->LeftPayloadIsEmpty()) {
+ ARROW_ASSIGN_OR_RAISE(left_payload,
local_state.exec_batch_payloads.Decode(
+ match_left.size(),
match_left.data()));
+ }
+
+ ExecBatch right_payload;
+ if (!schema_mgr_->RightPayloadIsEmpty()) {
+ ARROW_ASSIGN_OR_RAISE(right_payload, hash_table_payloads_.Decode(
+ match_right.size(),
match_right.data()));
+ }
Review comment:
Yep! I actually only knew to put these `if`s in because the Random test
caught it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
