houqp commented on issue #1248: URL: https://github.com/apache/arrow-datafusion/issues/1248#issuecomment-964864394
> columns(&self) -> Vec<ArrayRef>, and fn column(&self, i: usize) -> ArrayRef I think instead of returning `ArrayRef`, we should be returning `ColumnarValue` here? RLE can be something we use to further compress arrow record batches, but I think it is an overkill for constant columns because this use-case can already be covered by `ColumnarValue::Scalar`. I can see us adding it in the future for other use-cases though, perhaps as another variant to `ColumnarValue`?. `ColumnarValue::Scalar` is effectively an special case for RLE, which maps nicely to arrow compute kernels that are specialized to scalar operands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
