edponce commented on a change in pull request #11505:
URL: https://github.com/apache/arrow/pull/11505#discussion_r746354035
##########
File path: docs/source/developers/python.rst
##########
@@ -335,6 +335,11 @@ virtualenv) enables cmake to choose the python executable
which you are using.
For any other C++ build challenges, see :ref:`cpp-development`.
+In case you may need to rebuild the C++ part due to errors in the process it is
+advisable to delete the content of the build folder with command ``rm -rf *``
+from the build folder itself. If the build has passed successfully and you
need to rebuild
Review comment:
General comment: The typical workflow to reset a build when using cmake
is to remove the `<build dir>` not its contents.
##########
File path: docs/source/developers/cpp/building.rst
##########
@@ -121,9 +121,21 @@ argument is omitted then a release build will be produced.
.. note::
- You need to more options to build on Windows. See
+ You need to set more options to build on Windows. See
:ref:`developers-cpp-windows` for details.
+Other options for build type are also possible:
+
+* ``Debug``: doesn't apply any compiler optimizations and leaves debugging
+ information in the binary.
+* ``RelWithDebInfo``: applies compiler optimizations while leaving debug
+ information in the binary.
Review comment:
I suggest to change `leaves debugging information` to `adds debugging
information`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
