romainfrancois commented on a change in pull request #11534:
URL: https://github.com/apache/arrow/pull/11534#discussion_r746373495
##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -317,3 +317,7 @@ split_vector_as_list <- function(vec) {
vec2 <- vec[seq(from = min(length(vec), vec_split + 1), to = length(vec), by
= 1)]
list(vec1, vec2)
}
+
+err_helper <- function(...) (expect_error(...))
Review comment:
@paleolimbot one thing that really helped me was
`testthat::snapshot_review()`.
Also the `(expect_snapshot(` + `expect_error()` pattern has the benefit of
explicitly expecting an error from a specific expression, as opposed to merely
allow errors in one of the expressions in `expect_snapshot(error = TRUE)`, and
so have the test fail otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
