bkietz commented on a change in pull request #11579:
URL: https://github.com/apache/arrow/pull/11579#discussion_r746925318
##########
File path: cpp/src/arrow/compute/exec/expression.h
##########
@@ -91,6 +91,9 @@ class ARROW_EXPORT Expression {
/// Return true if this expression could evaluate to true.
bool IsSatisfiable() const;
+ /// Return true if this expression has no clauses.
+ bool IsEmpty() const;
Review comment:
If it were possible to forbid default construction of `Expression`
without breaking `vector<Expression>::resize` I would do so. As I've been
trying to express, it's not really valid for humans to write `Expression
defaulted;` but there's no attribute or pragma I'm aware of to make the
compiler warn about that. Maybe the solution is to add a large warning comment
for `Expression() = default;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
