lidavidm commented on a change in pull request #11670:
URL: https://github.com/apache/arrow/pull/11670#discussion_r746950198
##########
File path: cpp/src/arrow/array/util.cc
##########
@@ -363,19 +363,28 @@ class NullArrayFactory {
return Status::OK();
}
- Status Visit(const UnionType& type) {
+ Status Visit(const SparseUnionType& type) {
// type codes
RETURN_NOT_OK(MaxOf(length_));
- if (type.mode() == UnionMode::DENSE) {
- // offsets
- RETURN_NOT_OK(MaxOf(sizeof(int32_t) * length_));
- }
+ // will create children of the same length as the union
for (const auto& child : type.fields()) {
RETURN_NOT_OK(MaxOf(GetBufferLength(child->type(), length_)));
}
return Status::OK();
}
+ Status Visit(const DenseUnionType& type) {
+ // type codes
+ RETURN_NOT_OK(MaxOf(length_));
+ // offsets
+ RETURN_NOT_OK(MaxOf(sizeof(int32_t) * length_));
+ // will create children of length 1
Review comment:
We should clarify ARROW-13479 at some point…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
