matthewmturner commented on a change in pull request #1063:
URL: https://github.com/apache/arrow-datafusion/pull/1063#discussion_r747028225
##########
File path: datafusion/src/physical_optimizer/aggregate_statistics.rs
##########
@@ -250,38 +289,41 @@ mod tests {
}
/// Checks that the count optimization was applied and we still get the
right result
- async fn assert_count_optim_success(plan: HashAggregateExec) -> Result<()>
{
+ async fn assert_count_optim_success(
+ plan: HashAggregateExec,
+ nulls: bool,
+ ) -> Result<()> {
let conf = ExecutionConfig::new();
let optimized = AggregateStatistics::new().optimize(Arc::new(plan),
&conf)?;
+ let (col, count) = match nulls {
+ false => (Field::new("COUNT(Uint8(1))", DataType::UInt64, false),
3),
Review comment:
i think this is just a case of a poorly named variable. it should
really be something like `col_count` i.e. if the test is on a table count or
column count. when using datafusion-cli on this branch i get the same output
as what you showed. i will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
