thisisnic commented on a change in pull request #11680:
URL: https://github.com/apache/arrow/pull/11680#discussion_r747700771
##########
File path: r/tests/testthat/test-filesystem.R
##########
@@ -132,6 +132,19 @@ test_that("LocalFileSystem + Selector", {
expect_equal(sum(types == FileType$Directory), 1L)
})
+# This test_that block must be above the two that follow it because
S3FileSystem$create
+# uses a slightly different set of cpp code that is R-only, so if there are
bugs
+# in the initialization of S3 (e.g. ARROW-14667) they will not be caught
because
+# the blocks "FileSystem$from_uri" and "SubTreeFileSystem$create() with URI"
actually
+# initialize it
+test_that("S3FileSystem", {
+ skip_on_cran()
+ skip_if_not_available("s3")
+ skip_if_offline()
+ s3fs <- S3FileSystem$create()
+ expect_r6_class(s3fs, "S3FileSystem")
+})
Review comment:
Happy with this as the best solution that doesn't require additional
(and perhaps unnecessary) complexity though and as you say, the underlying
functionality is better tested in the C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
