ianmcook commented on pull request #11624: URL: https://github.com/apache/arrow/pull/11624#issuecomment-967245185
Bikeshedding on the method name: In other packages, the `group_by` method/function does not actually do any aggregation. Instead it serves as a helper function that tells a separate aggregate method/function what groups to aggregate over. Examples of this include Ibis (`group_by` --> `aggregate`), pandas (`groupby` --> `agg`), and dplyr (`group_by` --> `summarise`). Because of this I think we should pick a different name than `group_by` for this function, since it both groups and aggregates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
