xudong963 commented on a change in pull request #1288: URL: https://github.com/apache/arrow-datafusion/pull/1288#discussion_r748692070
########## File path: datafusion/src/catalog/schema.rs ########## @@ -101,4 +114,70 @@ impl SchemaProvider for MemorySchemaProvider { let mut tables = self.tables.write().unwrap(); Ok(tables.remove(name)) } + + fn table_exist(&self, name: &str) -> bool { Review comment: nit: we can keep the same as above, use `#[allow(unused_variables)]` instead of `_`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org