houqp commented on a change in pull request #1288:
URL: https://github.com/apache/arrow-datafusion/pull/1288#discussion_r748773992
##########
File path: datafusion/src/catalog/schema.rs
##########
@@ -57,6 +57,14 @@ pub trait SchemaProvider: Sync + Send {
"schema provider does not support deregistering tables".to_owned(),
))
}
+
+ /// If supported by the implementation, checks the table exist in the
schema provider or not.
+ /// If no matched table in the schema provider, return false.
+ /// Otherwise, return true.
+ #[allow(unused_variables)]
+ fn table_exist(&self, name: &str) -> bool {
Review comment:
this default implementation doesn't seem very useful, if we require
users to implement `fn table_names`, then i think it's reasonable to require
them to implement `table_exists` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
