wesm commented on a change in pull request #11687:
URL: https://github.com/apache/arrow/pull/11687#discussion_r748912798
##########
File path: cpp/src/arrow/python/numpy_to_arrow.cc
##########
@@ -662,7 +663,11 @@ Status NumPyConverter::Visit(const StringType& type) {
char numpy_byteorder = dtype_->byteorder;
// For Python C API, -1 is little-endian, 1 is big-endian
+#if ARROW_LITTLE_ENDIAN
Review comment:
Could you add a comment here to this effect (that both `|` and `<` yield
little-endian in the first case and `|` and `>` yield big-endian in the second
case)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
