nealrichardson commented on a change in pull request #11703:
URL: https://github.com/apache/arrow/pull/11703#discussion_r749306338
##########
File path: r/tools/nixlibs.R
##########
@@ -371,9 +371,17 @@ ensure_cmake <- function() {
if (is.null(cmake)) {
# If not found, download it
cat("**** cmake\n")
- CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.19.2")
+ CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.19.3")
if (tolower(Sys.info()[["sysname"]]) %in% "darwin") {
postfix <- "-macos-universal.tar.gz"
+ } else if (tolower(Sys.info()[["machine"]]) == "arm64") {
+ postfix <- "-linux-aarch64.tar.gz"
+ } else if (tolower(Sys.info()[["machine"]]) == "armv7l") { # e.g.
Raspberry Pi OS
Review comment:
```suggestion
} else {
```
##########
File path: r/tools/nixlibs.R
##########
@@ -371,9 +371,17 @@ ensure_cmake <- function() {
if (is.null(cmake)) {
# If not found, download it
cat("**** cmake\n")
- CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.19.2")
+ CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.19.3")
if (tolower(Sys.info()[["sysname"]]) %in% "darwin") {
postfix <- "-macos-universal.tar.gz"
+ } else if (tolower(Sys.info()[["machine"]]) == "arm64") {
+ postfix <- "-linux-aarch64.tar.gz"
+ } else if (tolower(Sys.info()[["machine"]]) == "armv7l") { # e.g.
Raspberry Pi OS
+ # It is unlikely that we would hit this logic as cmake is usual
installed with Pi OS
+ stop(paste0(
+ "*** cmake was not found locally and no binaries are available for
your architecture - it must be compiled from source",
Review comment:
Let's say less, just so CRAN doesn't get the right idea.
```suggestion
"*** cmake not available",
```
##########
File path: r/tools/nixlibs.R
##########
@@ -371,9 +371,17 @@ ensure_cmake <- function() {
if (is.null(cmake)) {
# If not found, download it
cat("**** cmake\n")
- CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.19.2")
+ CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.19.3")
if (tolower(Sys.info()[["sysname"]]) %in% "darwin") {
postfix <- "-macos-universal.tar.gz"
+ } else if (tolower(Sys.info()[["machine"]]) == "arm64") {
+ postfix <- "-linux-aarch64.tar.gz"
+ } else if (tolower(Sys.info()[["machine"]]) == "armv7l") { # e.g.
Raspberry Pi OS
+ # It is unlikely that we would hit this logic as cmake is usual
installed with Pi OS
Review comment:
```suggestion
```
##########
File path: r/tools/nixlibs.R
##########
@@ -371,9 +371,17 @@ ensure_cmake <- function() {
if (is.null(cmake)) {
# If not found, download it
cat("**** cmake\n")
- CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.19.2")
+ CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.19.3")
Review comment:
I'd just upgrade to the newest cmake there is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
