jorisvandenbossche commented on a change in pull request #11686:
URL: https://github.com/apache/arrow/pull/11686#discussion_r749371493
##########
File path: python/pyarrow/tests/test_pandas.py
##########
@@ -4328,9 +4328,14 @@ def make_df_with_timestamps():
})
# Not part of what we're testing, just ensuring that the inputs are what we
# expect.
+ if sys.byteorder == "little":
+ datetime_dtype = "<M8[ns]"
+ else:
+ datetime_dtype = ">M8[ns]"
assert (df.dateTimeMs.dtype, df.dateTimeNs.dtype) == (
- # O == object, <M8[ns] == timestamp64[ns]
- np.dtype("O"), np.dtype("<M8[ns]")
Review comment:
I am not super familiar with those endianness details, but would it be
sufficient to compare against `"M8[ns]"` as well? (so without the explicit `<`,
assuming the check is then robust across platforms)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
