lidavidm commented on pull request #11507: URL: https://github.com/apache/arrow/pull/11507#issuecomment-968991739
> Hey @lidavidm , about your question: > > > Actually, why not make GetFlightInfoForCommand and GetFlightInfo protected methods? > > Adding GetFlightInfoForCommand to the client header would leak `google::protobuf::Message` Ah, right…thanks for pointing that out. I suppose we could pImpl it but we'd still have to have some protected methods for mocking. It's fine as is then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
