alamb commented on a change in pull request #1300:
URL: https://github.com/apache/arrow-datafusion/pull/1300#discussion_r749719648
##########
File path: datafusion/tests/sql.rs
##########
@@ -1281,6 +1281,60 @@ async fn csv_query_approx_count() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn csv_query_array_agg() -> Result<()> {
+ let mut ctx = ExecutionContext::new();
+ register_aggregate_csv(&mut ctx).await?;
+ let sql =
+ "SELECT array_agg(c13) FROM (SELECT * FROM aggregate_test_100 LIMIT 2)
test";
Review comment:
can you please add an `ORDER BY` to this query - as written it may be
non deterministic (the first two values returned are not guaranteed to be in
any order):
```suggestion
"SELECT array_agg(c13) FROM (SELECT * FROM aggregate_test_100 ORDER
BY c13 LIMIT 2) test";
```
##########
File path: datafusion/tests/sql.rs
##########
@@ -1281,6 +1281,60 @@ async fn csv_query_approx_count() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn csv_query_array_agg() -> Result<()> {
+ let mut ctx = ExecutionContext::new();
+ register_aggregate_csv(&mut ctx).await?;
+ let sql =
+ "SELECT array_agg(c13) FROM (SELECT * FROM aggregate_test_100 LIMIT 2)
test";
+ let actual = execute_to_batches(&mut ctx, sql).await;
+ let expected = vec![
+ "+------------------------------------------------------------------+",
+ "| ARRAYAGG(test.c13) |",
+ "+------------------------------------------------------------------+",
+ "| [6WfVFBVGJSQb7FhA7E0lBwdvjfZnSW, C2GT5KVyOPZpgKVl110TyZO0NcJ434] |",
+ "+------------------------------------------------------------------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+ Ok(())
+}
+
+#[tokio::test]
+async fn csv_query_array_agg_empty() -> Result<()> {
Review comment:
👍
##########
File path: datafusion/tests/sql.rs
##########
@@ -1281,6 +1281,60 @@ async fn csv_query_approx_count() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn csv_query_array_agg() -> Result<()> {
+ let mut ctx = ExecutionContext::new();
+ register_aggregate_csv(&mut ctx).await?;
+ let sql =
+ "SELECT array_agg(c13) FROM (SELECT * FROM aggregate_test_100 LIMIT 2)
test";
+ let actual = execute_to_batches(&mut ctx, sql).await;
+ let expected = vec![
+ "+------------------------------------------------------------------+",
+ "| ARRAYAGG(test.c13) |",
+ "+------------------------------------------------------------------+",
+ "| [6WfVFBVGJSQb7FhA7E0lBwdvjfZnSW, C2GT5KVyOPZpgKVl110TyZO0NcJ434] |",
+ "+------------------------------------------------------------------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+ Ok(())
+}
+
+#[tokio::test]
+async fn csv_query_array_agg_empty() -> Result<()> {
+ let mut ctx = ExecutionContext::new();
+ register_aggregate_csv(&mut ctx).await?;
+ let sql =
+ "SELECT array_agg(c13) FROM (SELECT * FROM aggregate_test_100 LIMIT 0)
test";
+ let actual = execute_to_batches(&mut ctx, sql).await;
+ let expected = vec![
+ "+--------------------+",
+ "| ARRAYAGG(test.c13) |",
+ "+--------------------+",
+ "| [] |",
+ "+--------------------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+ Ok(())
+}
+
+#[tokio::test]
+async fn csv_query_array_agg_one() -> Result<()> {
+ let mut ctx = ExecutionContext::new();
+ register_aggregate_csv(&mut ctx).await?;
+ let sql =
+ "SELECT array_agg(c13) FROM (SELECT * FROM aggregate_test_100 LIMIT 1)
test";
Review comment:
same comment here about needing an `ORDER BY` please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
