Jimexist commented on a change in pull request #1285:
URL: https://github.com/apache/arrow-datafusion/pull/1285#discussion_r750909052
##########
File path: datafusion-cli/src/command.rs
##########
@@ -64,6 +67,15 @@ impl Command {
Self::Quit => Err(DataFusionError::Execution(
"Unexpected quit, this should be handled outside".into(),
)),
+ Self::ListFunctions => display_all_functions(),
+ Self::SearchFunctions(function) => {
+ if let Ok(func) = function.parse::<Function>() {
+ func.function_details()?
+ } else {
+ eprintln!("{} is not a supported function", function)
Review comment:
how about you just return error for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
