liukun4515 commented on a change in pull request #1317: URL: https://github.com/apache/arrow-datafusion/pull/1317#discussion_r750937475
########## File path: ballista/rust/core/src/serde/logical_plan/to_proto.rs ########## @@ -973,24 +973,24 @@ impl TryInto<protobuf::LogicalPlanNode> for &LogicalPlan { )), }) } - LogicalPlan::Analyze { verbose, input, .. } => { - let input: protobuf::LogicalPlanNode = input.as_ref().try_into()?; + LogicalPlan::Analyze(a) => { Review comment: It's better to import the Analyze struct and use this code style ``` LogicalPlan::Analyze(Aanlyze{ verbose, input,.... }) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org