emkornfield commented on a change in pull request #11710:
URL: https://github.com/apache/arrow/pull/11710#discussion_r751004090
##########
File path: cpp/src/parquet/encoding.cc
##########
@@ -2265,21 +2269,27 @@ class DeltaLengthByteArrayDecoder : public DecoderImpl,
}
int Decode(ByteArray* buffer, int max_values) override {
+ // Decode up to `max_values` strings into an internal buffer
+ // and reference them into `buffer`.
max_values = std::min(max_values, num_valid_values_);
- int64_t data_size = 0;
+ int32_t data_size = 0;
Review comment:
it is not immediately clear to me why this must be less than int32_t? I
guess I need to reread the spec on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
