kou commented on a change in pull request #11562: URL: https://github.com/apache/arrow/pull/11562#discussion_r750999494
########## File path: dev/release/README.md ########## @@ -22,3 +22,5 @@ To learn more, see the project wiki: https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide + +and [VERIFY.md](https://github.com/apache/arrow/blob/master/dev/release/VERIFY.md) Review comment: Can we use relative path here? ```suggestion and [VERIFY.md](VERIFY.md) ``` ########## File path: dev/release/VERIFY.md ########## @@ -74,3 +74,36 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS: ```console % export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH ``` + +### C++, C#, C GLib, Go, JavaScript, Python, Ruby + +Example scripts to install the dependencies to run the verification +script for verifying the source on Ubuntu 20.04, Rocky Linux 8 and +AlmaLinux 8 are in this folder and named `setup-ubuntu.sh` and +`setup-rhel-derivatives.sh`. These can be adapted to different +situations. Go and JavaScript are installed by the verification + Review comment: ```suggestion ``` ########## File path: dev/release/VERIFY.md ########## @@ -74,3 +74,36 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS: ```console % export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH ``` + +### C++, C#, C GLib, Go, JavaScript, Python, Ruby + +Example scripts to install the dependencies to run the verification +script for verifying the source on Ubuntu 20.04, Rocky Linux 8 and +AlmaLinux 8 are in this folder and named `setup-ubuntu.sh` and +`setup-rhel-derivatives.sh`. These can be adapted to different +situations. Go and JavaScript are installed by the verification + +script in the testing environment. Verifying the binaries additionally +requires installation of Docker. Verifying the wheels requires +installation of packages listed in `../../python/requirements-test.txt`, +and additionally requires running + +```console +git submodule init +git submodule update +``` Review comment: This instruction isn't needed. Because: 1. The verification script verifies in `apache-arrow-X.Y.Z/` that is created by extraction of `apache-arrow-X.Y.Z.tar.gz` not the checkout-ed directory. (No `.git/` in `apache-arrow-X.Y.Z/'.) 2. The verification script clones test data automatically: https://github.com/apache/arrow/blob/master/dev/release/verify-release-candidate.sh#L703 ########## File path: dev/release/setup-rhel-derivatives.sh ########## @@ -0,0 +1,52 @@ +#!/bin/sh -l +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +# A script to install dependencies required for release +# verification Red Hat Enterprise Linux 8 clones in particular +# on AlmaLinux 8 and Rocky Linux 8 + +dnf -y install \ + dnf-plugins-core +dnf config-manager --set-enabled powertools +dnf -y module disable ruby +dnf -y module enable ruby:2.7 +dnf -y groupinstall "Development Tools" +dnf -y install \ + cmake \ + epel-release \ + gdbm-devel \ + git \ + gobject-introspection-devel \ + java-1.8.0-openjdk-devel \ + libcurl-devel \ + libffi-devel \ + llvm-devel \ + llvm-toolset \ + maven \ + ncurses-devel \ Review comment: Is this needed? ########## File path: dev/release/setup-ubuntu.sh ########## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# A script to install dependencies required for release +# verification on Ubuntu 20.04 + +apt-get update +apt-get -y install \ + build-essential \ + clang \ + cmake \ + lblssl-dev \ Review comment: ```suggestion libssl-dev \ ``` ########## File path: dev/release/setup-rhel-derivatives.sh ########## @@ -0,0 +1,52 @@ +#!/bin/sh -l +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +# A script to install dependencies required for release +# verification Red Hat Enterprise Linux 8 clones in particular +# on AlmaLinux 8 and Rocky Linux 8 + +dnf -y install \ + dnf-plugins-core +dnf config-manager --set-enabled powertools +dnf -y module disable ruby +dnf -y module enable ruby:2.7 +dnf -y groupinstall "Development Tools" +dnf -y install \ + cmake \ + epel-release \ + gdbm-devel \ + git \ + gobject-introspection-devel \ + java-1.8.0-openjdk-devel \ + libcurl-devel \ + libffi-devel \ + llvm-devel \ + llvm-toolset \ + maven \ + ncurses-devel \ + ninja-build \ + openssl-devel \ + python3-pip \ + python3-devel \ + readline-devel \ + ruby-devel \ + wget +dnf -y upgrade +alias pip=pip3 Review comment: Is this needed? ########## File path: dev/release/setup-rhel-derivatives.sh ########## @@ -0,0 +1,52 @@ +#!/bin/sh -l +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +# A script to install dependencies required for release +# verification Red Hat Enterprise Linux 8 clones in particular +# on AlmaLinux 8 and Rocky Linux 8 + +dnf -y install \ + dnf-plugins-core +dnf config-manager --set-enabled powertools +dnf -y module disable ruby +dnf -y module enable ruby:2.7 +dnf -y groupinstall "Development Tools" +dnf -y install \ + cmake \ + epel-release \ + gdbm-devel \ Review comment: Is this needed? ########## File path: dev/release/setup-rhel-derivatives.sh ########## @@ -0,0 +1,52 @@ +#!/bin/sh -l +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +# A script to install dependencies required for release +# verification Red Hat Enterprise Linux 8 clones in particular +# on AlmaLinux 8 and Rocky Linux 8 + +dnf -y install \ + dnf-plugins-core Review comment: ```suggestion 'dnf-command(config-manager)' ``` ########## File path: dev/release/setup-rhel-derivatives.sh ########## @@ -0,0 +1,52 @@ +#!/bin/sh -l +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +# A script to install dependencies required for release +# verification Red Hat Enterprise Linux 8 clones in particular +# on AlmaLinux 8 and Rocky Linux 8 + +dnf -y install \ + dnf-plugins-core +dnf config-manager --set-enabled powertools +dnf -y module disable ruby +dnf -y module enable ruby:2.7 +dnf -y groupinstall "Development Tools" +dnf -y install \ + cmake \ + epel-release \ + gdbm-devel \ + git \ + gobject-introspection-devel \ + java-1.8.0-openjdk-devel \ + libcurl-devel \ + libffi-devel \ + llvm-devel \ + llvm-toolset \ + maven \ + ncurses-devel \ + ninja-build \ + openssl-devel \ + python3-pip \ + python3-devel \ + readline-devel \ Review comment: Is this needed? ########## File path: dev/release/setup-rhel-derivatives.sh ########## @@ -0,0 +1,52 @@ +#!/bin/sh -l +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +# A script to install dependencies required for release +# verification Red Hat Enterprise Linux 8 clones in particular +# on AlmaLinux 8 and Rocky Linux 8 + +dnf -y install \ + dnf-plugins-core +dnf config-manager --set-enabled powertools +dnf -y module disable ruby +dnf -y module enable ruby:2.7 +dnf -y groupinstall "Development Tools" +dnf -y install \ + cmake \ + epel-release \ + gdbm-devel \ + git \ + gobject-introspection-devel \ + java-1.8.0-openjdk-devel \ + libcurl-devel \ + libffi-devel \ Review comment: Is this needed? ########## File path: dev/release/setup-rhel-derivatives.sh ########## @@ -0,0 +1,52 @@ +#!/bin/sh -l Review comment: ```suggestion #!/bin/sh ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
